Skip to content

feat: add FIX descriptor engine integration #333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
swapnilraj wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

feat: add FIX descriptor engine integration #333

swapnilraj wants to merge 1 commit into from

Conversation

@swapnilraj
Copy link

@swapnilraj swapnilraj commented Nov 2, 2025 •
edited
Loading

Summary

  • add FixDescriptorEngine core contract plus module interface/wrapper to expose descriptor-driven metadata.
  • provide deployment-ready FIX variants of standalone and upgradeable CMTAT contracts (including UUPS).
  • supply mocks and test harnesses covering descriptor registration, CBOR validation, and module wiring.
  • update Hardhat configuration and package manifests so builds/test suites include the new FIX engine.

Design

  • Specification for the original erc-fix.com/spec adapted for the CMTAT contracts
  • FIX descriptor logic keeps CBOR storage off-chain; contracts only ingest hashes and pointers, keeping deployment costs flat.
  • Wrapper module isolates descriptor engine behind IFixDescriptorEngineModule, so existing deployments can toggle the feature with minimal surface change.
  • Deployment contracts compose the base modules rather than duplicating logic, preventing drift with non-FIX variants.

@swapnilraj
feat: add FIX descriptor engine integration
eb78d8b 
- introduce FixDescriptorEngine contracts, interfaces, and wrapper modules
- add FIX-aware deployment variants for standalone and upgradeable CMTAT
- supply mocks, harnesses, and tests to validate the FIX descriptor flow
- update Hardhat config and package manifests for the new engine support
@rya-sge
Copy link
Collaborator

rya-sge commented Nov 13, 2025 •
edited
Loading

Hello @swapnilraj ,

Thanks a lot for your PR, great work !

Some questions:

  1. Engines are generally put in a dedicated repository. Is it Ok for you if we create a new repository inside CMTA so you can add the engine here ?

  2. Do you have planned to keep fix-descriptor in your GitHub or it will move to a GitHub managed by an organisation ?

Due to the dependence with the SDK, I will be more favorable if we put all the fix dedicated smart contracts (including modules and deployment version) in a dedicated repository instead of the main CMTAT repository.
In this case, we could have the engine and all CMTAT related modification in the same repository.

We already do this for the SnapshotEngine, which also contains a specific deployment version with modules for CMTAT: SnapshotEngine

This dedicated repository could be host in your GitHub or in CMTA organisation as you prefer.

Feel free to contact me on X if you have questions

@rya-sge
Copy link
Collaborator

rya-sge commented Dec 16, 2025

As discussed, the code will be moved to a dedicated repository: CMTAT-FIX

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@swapnilraj @rya-sge